fix(idempotency): treat missing idempotency key as non-idempotent transaction (no-op) when raise_on_no_idempotency_key is False #2477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leandrodamascena
requested review from
heitorlessa
and removed request for
a team
boring-cyborg
bot
added
documentation
pull-request-size
bot
added
the
size/M
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #2477 +/- ##
===========================================
- Coverage 97.22% 96.96% -0.26%
===========================================
Files 157 157
Lines 7306 7212 -94
Branches 523 514 -9
===========================================
- Hits 7103 6993 -110
- Misses 158 168 +10
- Partials 45 51 +6
☔ View full report in Codecov by Sentry. |
|
looking |
|
LGTM, sending an E2E test to be triple sure |
pull-request-size
bot
added
size/L
heitorlessa
reviewed
Jun 16, 2023
aws_lambda_powertools/utilities/idempotency/persistence/base.py
Outdated
Show resolved
Hide resolved
heitorlessa
reviewed
Jun 16, 2023
Signed-off-by: Heitor Lessa <[email protected]>
Signed-off-by: Heitor Lessa <[email protected]>
heitorlessa
reviewed
Jun 16, 2023
aws_lambda_powertools/utilities/idempotency/persistence/base.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Heitor Lessa <[email protected]>
heitorlessa
changed the title
heitorlessa
approved these changes
Jun 16, 2023
sthulb
pushed a commit
that referenced
this pull request
Jun 19, 2023
…nsaction (no-op) when raise_on_no_idempotency_key is False (#2477) * bug: fix missing idempotency key * fix return * chore: add e2e test for optional idempotency key * chore: fix e2e third payload * docs: clarify operations Signed-off-by: Heitor Lessa <[email protected]> * chore: clarify warning Signed-off-by: Heitor Lessa <[email protected]> * chore: strip extra space Signed-off-by: Heitor Lessa <[email protected]> * chore: ignore long warning line --------- Signed-off-by: Heitor Lessa <[email protected]> Co-authored-by: heitorlessa <[email protected]> Co-authored-by: Heitor Lessa <[email protected]>
rafaelgsr
pushed a commit
to rafaelgsr/aws-lambda-powertools-python
that referenced
this pull request
Jun 30, 2023
…nsaction (no-op) when raise_on_no_idempotency_key is False (aws-powertools#2477) * bug: fix missing idempotency key * fix return * chore: add e2e test for optional idempotency key * chore: fix e2e third payload * docs: clarify operations Signed-off-by: Heitor Lessa <[email protected]> * chore: clarify warning Signed-off-by: Heitor Lessa <[email protected]> * chore: strip extra space Signed-off-by: Heitor Lessa <[email protected]> * chore: ignore long warning line --------- Signed-off-by: Heitor Lessa <[email protected]> Co-authored-by: heitorlessa <[email protected]> Co-authored-by: Heitor Lessa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #2465
Summary
Changes
This PR addresses the issue where idempotency data could be inadvertently persisted when the corresponding idempotency key is missing. This fix prevents any potential inconsistencies or undesired outcomes that may occur due to missing idempotency keys.
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.